Launcher color change propType added #149
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaumanMoazzam
requested review from
heatherbooker,
nnur and
dharness
and removed request for
heatherbooker
dharness
requested changes
Jun 23, 2020
| @@ -47,7 +47,7 @@ class Launcher extends Component { | |||
| ]; | |||
| return ( | |||
| <div id="sc-launcher"> | |||
| <div className={classList.join(' ')} onClick={this.handleClick.bind(this)}> | |||
| <div className={classList.join(' ')} onClick={this.handleClick.bind(this)} style={{background: `${this.props.launcherColor}`}}> | |||
There was a problem hiding this comment.
It would be preferable to do this via the classList - inline styles can create confusion down the line.
| @@ -11,7 +11,7 @@ class Launcher extends Component { | |||
| super(); | |||
| this.state = { | |||
| launcherIcon, | |||
| isOpen: false | |||
| isOpen: false, | |||
There was a problem hiding this comment.
Let's be consistent with our commas across the repo. If there is not consistency already, this change is unwarranted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Launcher color can be changed by the user
Checklist
npm start) to ensure it still functions as expected, and/ornpm run lintpasses (npm run lint -- --fixwill autofix where possible)